-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/node/manager: Fix inconsistent ipset entries handling on node update, add test non-regression test #29986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
added
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
release-note/ci
This PR makes changes to the CI.
labels
Dec 19, 2023
/test |
qmonnet
added
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
Dec 19, 2023
qmonnet
commented
Dec 20, 2023
qmonnet
added
kind/bug
This is a bug in the Cilium logic.
sig/agent
Cilium agent related.
labels
Dec 20, 2023
qmonnet
force-pushed
the
pr/qmonnet/manager-ipset-test
branch
from
January 4, 2024 11:36
6975d7f
to
60a97eb
Compare
/test |
qmonnet
added
release-note/bug
This PR fixes an issue in a previous release of Cilium.
and removed
release-note/ci
This PR makes changes to the CI.
labels
Jan 4, 2024
mhofstetter
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cli
✔️
thanks!
gandro
approved these changes
Jan 8, 2024
pchaigno
reviewed
Jan 8, 2024
maintainer-s-little-helper
bot
added
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
labels
Jan 8, 2024
qmonnet
removed
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jan 8, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jan 8, 2024
qmonnet
added
the
dont-merge/discussion
A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status.
label
Jan 8, 2024
qmonnet
changed the title
pkg/node/manager: Add test to validate ipset entries
pkg/node/manager: Fix inconsistent ipset entries handling on node update, add test non-regression test
Jan 8, 2024
qmonnet
force-pushed
the
pr/qmonnet/manager-ipset-test
branch
from
January 8, 2024 14:52
60a97eb
to
4480462
Compare
qmonnet
removed
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
dont-merge/discussion
A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status.
labels
Jan 8, 2024
/test |
pchaigno
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, apart from the couple notes on the release note.
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jan 8, 2024
qmonnet
added
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
and removed
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
labels
Jan 11, 2024
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.6
Jan 11, 2024
2 tasks
jibi
added
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
and removed
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
Jan 12, 2024
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in v1.15.0-rc.1
Jan 12, 2024
github-actions
bot
added
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
and removed
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
labels
Jan 15, 2024
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.6
Jan 15, 2024
giorio94
added
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
and removed
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
labels
Jan 29, 2024
maintainer-s-little-helper
bot
moved this from Backport pending to v1.15
to Backport done to v1.15
in v1.15.0-rc.1
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
kind/bug
This is a bug in the Cilium logic.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
sig/agent
Cilium agent related.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a bug on the v1.13 branch in the way we update the list of ipset entries in the node manager, add a test to ensure that entries are added or removed as we expect on node updates.
This is a forward port of the test added first to branch v1.13, commit 9ec163aff6f ("pkg/node/manager: Add test to validate ipset entries"), although the test has been reworked to use a mock ipset manager instead of checking the real ipset (which required privileges).
Related: #29898
[EDIT] Added an additional commit to fix the inconsistent behaviour on ipset entry handling in the node manager.