Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reference new repo for OpenShift installation #30736

Closed
wants to merge 1 commit into from

Conversation

fgiloux
Copy link

@fgiloux fgiloux commented Feb 13, 2024

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible. [NA]
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue. [NA]
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes. [NA]
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

cilium/cilium-olm has been deprecated and archived in favour of isovalent/olm-for-cilium. This PR updates the documentation page for OpenShift installation to reflect it. It also adds a few common pitfalls.

cilium/cilium-olm has been deprecated in favour of
isovalent/olm-for-cilium.
Common pitfalls have been also added.

Signed-off-by: Frederic Giloux <frederic.giloux@isovalent.com>
@fgiloux fgiloux requested a review from a team as a code owner February 13, 2024 11:15
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 13, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Feb 13, 2024
@joestringer
Copy link
Member

Sorry, I didn't realize you also had a proposal out in this area and that it conflicted with #29300 (fixes #24270). Perhaps you and @learnitall (and others interested) could get together and figure out the right path forward?

@learnitall
Copy link
Contributor

learnitall commented Feb 13, 2024

@fgiloux we essentially moved the guide over to https://github.com/isovalent/olm-for-cilium. The note that you added in this PR would be a nice addition there if you'd like to open another PR.

.. note::

   OpenShift installations use a different default port than Cilium for VXLAN: UDP 4789 (IANA) instead of UDP 8472 (Linux).
   Low range ports are also often blocked on OpenShift clusters. The port for cluster health needs to be open or
   configured to a higher range, e.g. ``clusterHealthPort: 9940``.
   The configuration used for conformance tests in isovalent/olm-for-cilium can be leveraged for a quick setup.

@fgiloux
Copy link
Author

fgiloux commented Feb 14, 2024

@learnitall I was aware of the doc move PR. It was open for 2.5 months and merged after I opened this one. I will open a PR in olm-for-cilium.

@fgiloux fgiloux closed this Feb 14, 2024
@fgiloux fgiloux deleted the pr/fgiloux/openshift-doc branch April 8, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. kind/community-contribution This was a contribution made by a community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants