Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Restructure OpenShift installation instructions #29300

Merged

Conversation

learnitall
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

This commit restructures the OpenShift installation instructions to point to the Red Hat Ecosystem Catalog, so users may find vendor maintained OLM images.

The old installation instructions which refer to the deprecated cilium/cilium-olm repository will be moved to the
isovalent/olm-for-cilium repository. The PR for this move can be found here: isovalent/olm-for-cilium#48.

Feedback on wording here is much appreciated, thank you!

Fixes: #24270

Restructure OpenShift installation instructions to point to Red Hat Ecosystem Catalog

@learnitall learnitall added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Nov 20, 2023
@learnitall learnitall requested a review from a team as a code owner November 20, 2023 23:37
@learnitall learnitall force-pushed the pr/learnitall/update-openshift-docs branch from 97f778c to 57a8c9f Compare November 20, 2023 23:40
@learnitall learnitall force-pushed the pr/learnitall/update-openshift-docs branch from 57a8c9f to e0653f9 Compare November 21, 2023 17:24
@saintdle
Copy link
Contributor

saintdle commented Dec 5, 2023

Shouldn't we point to the product page? https://catalog.redhat.com/software/container-stacks/detail/60423ec2c00b1279ffe35a68

Copy link

github-actions bot commented Jan 5, 2024

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 5, 2024
Copy link

This pull request has not seen any activity since it was marked stale.
Closing.

@github-actions github-actions bot closed this Jan 19, 2024
This commit restructures the OpenShift installation instructions to
point to the Red Hat Ecosystem Catalog, so users may find vendor
maintained OLM images.

The old installation instructions which refer to the deprecated
cilium/cilium-olm repository will be moved to the
isovalent/olm-for-cilium repository.

Fixes: cilium#24270

Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
@learnitall learnitall added pinned These issues are not marked stale by our issue bot. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Jan 22, 2024
@learnitall learnitall reopened this Jan 22, 2024
@learnitall learnitall force-pushed the pr/learnitall/update-openshift-docs branch from e0653f9 to e21b2c3 Compare January 22, 2024 18:38
@learnitall
Copy link
Contributor Author

Sorry for letting this go stale folks- lost track of it after the holidays. @saintdle I added a link to the software page.

@joestringer joestringer removed their request for review January 22, 2024 21:36
@joestringer
Copy link
Member

joestringer commented Feb 13, 2024

@fgiloux are you saying that something needs to change in this PR or just making other contributors aware of your efforts?

@joestringer
Copy link
Member

Oh I see what you mean.
image

@joestringer joestringer merged commit efff613 into cilium:main Feb 13, 2024
59 checks passed
@julianwiedmann julianwiedmann added the platform/openshift Related to using Cilium with OpenShift. label Apr 1, 2024
@julianwiedmann
Copy link
Member

Let's backport, so users can benefit from these doc updates (eg. #31577). From looking at the changes, I presume this applies across all releases. Please shout if that's not the case.

@julianwiedmann julianwiedmann added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 2, 2024
@joamaki joamaki mentioned this pull request Apr 2, 2024
8 tasks
@joamaki joamaki added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 2, 2024
@joamaki joamaki mentioned this pull request Apr 2, 2024
10 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Apr 2, 2024
@joamaki joamaki mentioned this pull request Apr 2, 2024
13 tasks
@joamaki joamaki added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 2, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. pinned These issues are not marked stale by our issue bot. platform/openshift Related to using Cilium with OpenShift. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OpenShift documentation
8 participants