Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: Fix VTEP drop check #31039

Merged
merged 1 commit into from Feb 29, 2024
Merged

bpf: Fix VTEP drop check #31039

merged 1 commit into from Feb 29, 2024

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Feb 28, 2024 •
edited

Commit a94fa56 ("Fix CIDR to World Entity Conversion Bug") seems to
have inadvertently swapped a check for "is not world" to a check for "is
world" in order to drop. This has likely broken the VTEP feature. Fix
it.

Fixes: a94fa56 ("Fix CIDR to World Entity Conversion Bug")
Fixes: #22625
Fixes: #31023

Fix bug in the VTEP feature which caused all traffic from the VTEP to be dropped with "Incorrect VNI from VTEP"

@joestringer joestringer added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Feb 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.2 Feb 28, 2024
@joestringer
bpf: Fix VTEP drop check
7f87fba 
Commit a94fa56 ("Fix CIDR to World Entity Conversion Bug") seems to
have inadvertently swapped a check for "is not world" to a check for "is
world" in order to drop. This has likely broken the VTEP feature. Fix
it.

Fixes: a94fa56 ("Fix CIDR to World Entity Conversion Bug")
Reported-by: Jan Hugo Prins <jhp@jhprins.org>
Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer
Copy link
Member Author

/test

@vincentmli
Copy link
Contributor

@joestringer I validated the fix with latest master branch and build the cilium image, it works, thanks for the fix

@vincentmli vincentmli mentioned this pull request Feb 28, 2024
Closed
3 tasks
@joestringer joestringer marked this pull request as ready for review February 28, 2024 23:54
@joestringer joestringer requested a review from a team as a code owner February 28, 2024 23:54
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. feature/vtep Support for interacting with VXLAN Tunnel Endpoints (VTEPs) for traffic onboarding to the cluster kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. kind/bug This is a bug in the Cilium logic. labels Feb 29, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 5d3c7c3 Feb 29, 2024
228 checks passed
@julianwiedmann julianwiedmann deleted the pr/joe/fix-vtep branch February 29, 2024 07:05
@pippolo84 pippolo84 mentioned this pull request Mar 5, 2024
Merged
13 tasks
@pippolo84 pippolo84 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 5, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in 1.15.2 Mar 5, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Mar 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.15 in 1.15.2 Mar 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.15 in 1.15.2 Mar 11, 2024
@marseel marseel mentioned this pull request Mar 11, 2024
Closed
@jrajahalme jrajahalme mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianwiedmann julianwiedmann julianwiedmann approved these changes

@nathanjsweet nathanjsweet Awaiting requested review from nathanjsweet

Assignees
No one assigned
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. feature/vtep Support for interacting with VXLAN Tunnel Endpoints (VTEPs) for traffic onboarding to the cluster kind/bug This is a bug in the Cilium logic. kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.15.2
Backport done to v1.15
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VTEP traffic is dropped when cluster is configured in VXLAN tunnel mode.
4 participants
@joestringer @vincentmli @julianwiedmann @pippolo84