Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: Remove redundant pod spec checks #31105

Merged

Conversation

aditighag
Copy link
Member

See commit messages.

Kubernetes validates these fields, so additional
checks are not required.

Example:

```
The Pod "be" is invalid: spec.containers[0].ports[0].containerPort: Invalid value: 65540: must be between 1 and 65535, inclusive

The Pod "be" is invalid: spec.containers[0].ports[0].protocol: Unsupported value: "icmp": supported values: "SCTP", "TCP", "UDP"
```

Signed-off-by: Aditi Ghag <aditi@cilium.io>
Kubernetes validates these fields, so additional
checks are not required.

Example:

```
The Pod "be" is invalid: spec.containers[0].ports[0].containerPort: Invalid value: 65540: must be between 1 and 65535, inclusive

```

Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag aditighag added the release-note/misc This PR makes changes that have no direct user impact. label Mar 2, 2024
@aditighag aditighag requested review from a team as code owners March 2, 2024 02:26
Copy link
Member

@ysksuzuki ysksuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 4, 2024
@aditighag
Copy link
Member Author

No need to run the full CI.

@joestringer joestringer merged commit aec875f into cilium:main Mar 4, 2024
45 checks passed
@aditighag aditighag deleted the pr/aditighag/remove-pod-spec-checks branch March 4, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants