Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: Remove redundant pod spec checks #31105

Merged
merged 2 commits into from
Mar 4, 2024
Merged

agent: Remove redundant pod spec checks #31105

merged 2 commits into from
Mar 4, 2024

Commits on Mar 2, 2024

  1. lrp: Remove redundant pod spec validations 

    Kubernetes validates these fields, so additional
checks are not required.

Example:

```
The Pod "be" is invalid: spec.containers[0].ports[0].containerPort: Invalid value: 65540: must be between 1 and 65535, inclusive

The Pod "be" is invalid: spec.containers[0].ports[0].protocol: Unsupported value: "icmp": supported values: "SCTP", "TCP", "UDP"
```

Signed-off-by: Aditi Ghag <aditi@cilium.io>
    @aditighag
    aditighag committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    c1319bd View commit details
    Browse the repository at this point in the history

  2. lrp: Remove redundant pod spec validations 

    Kubernetes validates these fields, so additional
checks are not required.

Example:

```
The Pod "be" is invalid: spec.containers[0].ports[0].containerPort: Invalid value: 65540: must be between 1 and 65535, inclusive

```

Signed-off-by: Aditi Ghag <aditi@cilium.io>
    @aditighag
    aditighag committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    38332a5 View commit details
    Browse the repository at this point in the history