Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh: workflows: clarify reference to issue #23283 #31118

Merged
merged 1 commit into from Mar 15, 2024
Merged

gh: workflows: clarify reference to issue #23283 #31118

merged 1 commit into from Mar 15, 2024

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Mar 4, 2024 •
edited

Clarify that while the issue was closed as resolved, this actually only
applies to scenarios where the kind.sh script is used.

@julianwiedmann julianwiedmann added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. area/multipool Affects Multi-Pool IPAM labels Mar 4, 2024
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review March 4, 2024 08:23
@julianwiedmann julianwiedmann requested review from a team as code owners March 4, 2024 08:23
@julianwiedmann julianwiedmann marked this pull request as draft March 4, 2024 08:38
@aanm
Copy link
Member

aanm commented Mar 4, 2024

@julianwiedmann FYI that since this is being opened from a fork I'm not sure if this is being tested with your changes or not.

@gandro
Copy link
Member

gandro commented Mar 4, 2024

Issue #23283 has been resolved, clean up the workarounds.

Could you like to the PR which has resolved this? Because last time I checked, the underlying issue wasn't actually fixed in Cilium, it was only "resolved" by adjusting the kind.sh script. But the workflows here use helm/kind-action, not kind.sh, thus they failed (that's at least why the multi-pool workflow has the mention, we discovered it "the hard way").

See also my comment here: #23283 (comment)

gandro
gandro requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(as per comment above)

@julianwiedmann
gh: workflows: clarify reference to issue cilium#23283
745c49f 
Clarify that while the issue was closed as resolved, this actually only
applies to scenarios where the kind.sh script is used.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann changed the title gh: workflows: remove workaround / reference to issue #23283 gh: workflows: clarify reference to issue #23283 Mar 4, 2024
@julianwiedmann
Copy link
Member Author

Issue #23283 has been resolved, clean up the workarounds.

Could you like to the PR which has resolved this? Because last time I checked, the underlying issue wasn't actually fixed in Cilium, it was only "resolved" by adjusting the kind.sh script. But the workflows here use helm/kind-action, not kind.sh, thus they failed (that's at least why the multi-pool workflow has the mention, we discovered it "the hard way").

See also my comment here: #23283 (comment)

Thanks! Marco pointed out the same to me earlier, we came to the conclusion that it's probably best to point right at your :amaze: comment and not the high-level issue. Updated the PR.

@julianwiedmann julianwiedmann marked this pull request as ready for review March 4, 2024 15:58
@julianwiedmann
Copy link
Member Author

/test

gandro
gandro approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 15, 2024
@YutaroHayakawa YutaroHayakawa added this pull request to the merge queue Mar 15, 2024
Merged via the queue into cilium:main with commit 8c23fa8 Mar 15, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/multipool Affects Multi-Pool IPAM ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@julianwiedmann @aanm @gandro @christarazi @YutaroHayakawa