-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Update pod affinity for cilium-envoy #31150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
a18ede6
to
faefad3
Compare
/test |
faefad3
to
7b9c29a
Compare
/test |
aanm
requested changes
Mar 6, 2024
squeed
reviewed
Mar 11, 2024
Convert to draft to address review comments. |
7b9c29a
to
5b3de7f
Compare
/test |
5b3de7f
to
62cca9c
Compare
/test |
62cca9c
to
e2eb48a
Compare
44d1133
to
d747c54
Compare
/test |
This commit is to avoid cilium-envoy running on the node without cilium agent. Two main changes are: - nodeAffinity to make sure that cilium-envoy will not be scheduled on node without cilium agent - podAffinity with requiredDuringSchedulingIgnoredDuringExecution to cilium agent Relates: cilium#25081, cilium#30034 Fixes: cilium#31149 Signed-off-by: Tam Mach <tam.mach@cilium.io>
d747c54
to
d5289f0
Compare
/test |
joamaki
approved these changes
Mar 13, 2024
aanm
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to avoid cilium-envoy running on the node without cilium
agent.
Relates: #25081, #30034
Fixes: #31149
Signed-off-by: Tam Mach tam.mach@cilium.io