gateway-api: shorten the length of the value of the svc's label. #31292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
chaunceyjiang
commented
Mar 11, 2024
|
/test |
sayboras
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
chaunceyjiang
force-pushed
the
svc_label
branch
from
620b887
to
dd91d3e
Compare
Fixes cilium#31285 When creating a gateway-api with a name exceeding 64 characters, it is impossible to create svc. This is because the label of svc references the name of gateway-api. Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
chaunceyjiang
force-pushed
the
svc_label
branch
from
dd91d3e
to
fc2588a
Compare
|
/test |
sayboras
added
needs-backport/1.13
|
@sayboras is there any way this could cause a collision that then has unexpected behaviour? For instance between two resources with long names, maybe with the same prefix? |
This was referenced Mar 12, 2024
sayboras
added
the
backport/author
3 tasks
sayboras
added
backport-pending/1.15
github-actions
bot
added
backport-done/1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31285
When creating a gateway-api with a name exceeding 64 characters, it is impossible to create svc.
This is because the label of svc references the name of gateway-api.