Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix filename-access example #2335

Merged

Conversation

yukinakanaka
Copy link
Contributor

Fixes: #2334

A demo pod called xwing doesn't seem to have vi now. This may be because of the image update: #2311, cilium/cilium#31373.

So, I propose creating a new busybox pod instead of xwing.

@yukinakanaka yukinakanaka requested review from mtardy and a team as code owners April 14, 2024 02:49
Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 0f6c97d
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6624bedf2f47fd0008a60c15
😎 Deploy Preview https://deploy-preview-2335--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yukinakanaka
Copy link
Contributor Author

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, that works fine, I don't mind not using the star wars deployments for this example! I just added a nit to change file-access-pod to file-access just to avoid the "file-access-pod Pod" stutter!

Another thing is that we could put the tetra getevents after the creation of the pod so that people are not confused with all the events that will appear at the pod creation. We can still put it before if we really want it but we should make a note on what are all those events.

This is mostly nits, and correct things the tutorial was not respecting even before (saying Pod instead of pod), so we can merge this anyway if you don't feel like the fix are worth it!

docs/content/en/docs/use-cases/filename-access.md Outdated Show resolved Hide resolved
docs/content/en/docs/use-cases/filename-access.md Outdated Show resolved Hide resolved
docs/content/en/docs/use-cases/filename-access.md Outdated Show resolved Hide resolved
docs/content/en/docs/use-cases/filename-access.md Outdated Show resolved Hide resolved
docs/content/en/docs/use-cases/filename-access.md Outdated Show resolved Hide resolved
docs/content/en/docs/use-cases/filename-access.md Outdated Show resolved Hide resolved
docs/content/en/docs/use-cases/filename-access.md Outdated Show resolved Hide resolved
docs/content/en/docs/use-cases/filename-access.md Outdated Show resolved Hide resolved
docs/content/en/docs/use-cases/filename-access.md Outdated Show resolved Hide resolved
docs/content/en/docs/use-cases/filename-access.md Outdated Show resolved Hide resolved
@mtardy mtardy added kind/bug Something isn't working area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Apr 19, 2024
@mtardy mtardy self-assigned this Apr 19, 2024
@yukinakanaka yukinakanaka force-pushed the pr/yukinakanaka/docs-filename-access branch from 429672e to 52e2bae Compare April 21, 2024 07:09
Signed-off-by: yukinakanaka <yuki.nakamura@mapbox.com>
@yukinakanaka yukinakanaka force-pushed the pr/yukinakanaka/docs-filename-access branch from 52e2bae to 0f6c97d Compare April 21, 2024 07:23
@yukinakanaka
Copy link
Contributor Author

Thank you for your kind review! I fixed up my commit by following your suggestion.

  • Change the pod name to file-access from file-access-pod.
  • Use Pod instead of pod.

Another thing is that we could put the tetra getevents after the creation of the pod so that people are not confused with all the events that will appear at the pod creation.

That's true. I put tetra getevents after the creation of pod.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!!

@mtardy mtardy merged commit dfc2bb1 into cilium:main Apr 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation kind/bug Something isn't working release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: demo application xwing doesn't have vi
2 participants