-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix filename-access example #2335
docs: fix filename-access example #2335
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
You can see the preview here: https://deploy-preview-2335--tetragon.netlify.app/docs/use-cases/filename-access/#examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, that works fine, I don't mind not using the star wars deployments for this example! I just added a nit to change file-access-pod
to file-access
just to avoid the "file-access-pod Pod" stutter!
Another thing is that we could put the tetra getevents
after the creation of the pod so that people are not confused with all the events that will appear at the pod creation. We can still put it before if we really want it but we should make a note on what are all those events.
This is mostly nits, and correct things the tutorial was not respecting even before (saying Pod instead of pod), so we can merge this anyway if you don't feel like the fix are worth it!
429672e
to
52e2bae
Compare
Signed-off-by: yukinakanaka <yuki.nakamura@mapbox.com>
52e2bae
to
0f6c97d
Compare
Thank you for your kind review! I fixed up my commit by following your suggestion.
That's true. I put tetra getevents after the creation of pod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!!
Fixes: #2334
A demo pod called
xwing
doesn't seem to havevi
now. This may be because of the image update: #2311, cilium/cilium#31373.So, I propose creating a new
busybox
pod instead ofxwing
.