New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "node-map-max" to allow configuring nodemap size. #31407
Add "node-map-max" to allow configuring nodemap size. #31407
Conversation
/test |
aca1a21
to
5e31f7b
Compare
/test |
5e31f7b
to
430cf12
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need documentation in https://docs.cilium.io/en/latest/network/ebpf/maps/#ebpf-maps. A few generated files are also missing but the CI already highlighted it.
I'd be in favor of backporting to at least the latest OSS release given without this some users may hit error logs that can't be avoided in any other way. |
bbc4154
to
18128d8
Compare
/test |
The Helm workflow is failing due to some files not being regenerated (e.g. the values.yaml file), but otherwise this looks good to me. Make sure to run
|
18128d8
to
2c6b13e
Compare
/test |
Looks like quay was done for ci images. |
/test |
@tommyp1ckles This PR depends on changes around the |
Using the node-map-max flag, one can now override the default 16k node map size.
This may be needed for large clusters, where the number of distinct node IPs in the cluster exceeds the standard size.
In helm, this will allow overriding the size using
bpf.nodeMapMax: <size>