Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "node-map-max" to allow configuring nodemap size. #31407

Merged
merged 4 commits into from Mar 26, 2024

Conversation

tommyp1ckles
Copy link
Contributor

Using the node-map-max flag, one can now override the default 16k node map size.
This may be needed for large clusters, where the number of distinct node IPs in the cluster exceeds the standard size.

In helm, this will allow overriding the size using bpf.nodeMapMax: <size>

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 15, 2024
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles force-pushed the pr/tp/adjustable-node-map-size branch from aca1a21 to 5e31f7b Compare March 15, 2024 04:03
@tommyp1ckles tommyp1ckles added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Mar 15, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 15, 2024
@tommyp1ckles tommyp1ckles added the sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. label Mar 15, 2024
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles marked this pull request as ready for review March 15, 2024 04:33
@tommyp1ckles tommyp1ckles requested review from a team as code owners March 15, 2024 04:33
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/adjustable-node-map-size branch from 5e31f7b to 430cf12 Compare March 15, 2024 05:01
@tommyp1ckles
Copy link
Contributor Author

/test

Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need documentation in https://docs.cilium.io/en/latest/network/ebpf/maps/#ebpf-maps. A few generated files are also missing but the CI already highlighted it.

pkg/maps/nodemap/cell.go Outdated Show resolved Hide resolved
@pchaigno pchaigno removed the request for review from markpash March 15, 2024 11:08
@pchaigno
Copy link
Member

I'd be in favor of backporting to at least the latest OSS release given without this some users may hit error logs that can't be avoided in any other way.

@tommyp1ckles tommyp1ckles force-pushed the pr/tp/adjustable-node-map-size branch 2 times, most recently from bbc4154 to 18128d8 Compare March 15, 2024 16:07
@tommyp1ckles
Copy link
Contributor Author

/test

@gandro
Copy link
Member

gandro commented Mar 18, 2024

The Helm workflow is failing due to some files not being regenerated (e.g. the values.yaml file), but otherwise this looks good to me.

Make sure to run

make -C install/kubernetes
make -C Documentation update-helm-values

@tommyp1ckles tommyp1ckles force-pushed the pr/tp/adjustable-node-map-size branch from 18128d8 to 2c6b13e Compare March 18, 2024 17:47
@tommyp1ckles tommyp1ckles added the affects/v1.15 This issue affects v1.15 branch label Mar 18, 2024
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles
Copy link
Contributor Author

Looks like quay was done for ci images.

auto-merge was automatically disabled March 26, 2024 03:51

Pull request was closed

@tommyp1ckles tommyp1ckles reopened this Mar 26, 2024
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles added this pull request to the merge queue Mar 26, 2024
Merged via the queue into cilium:main with commit 4367ffa Mar 26, 2024
85 of 104 checks passed
@tommyp1ckles tommyp1ckles deleted the pr/tp/adjustable-node-map-size branch March 26, 2024 05:50
@tommyp1ckles tommyp1ckles added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. labels Mar 26, 2024
@julianwiedmann julianwiedmann added needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch and removed affects/v1.14 This issue affects v1.14 branch backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. affects/v1.15 This issue affects v1.15 branch labels Mar 26, 2024
@joamaki joamaki added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 2, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Apr 8, 2024
@nbusseneau nbusseneau added the backport/author The backport will be carried out by the author of the PR. label Apr 10, 2024
@nbusseneau
Copy link
Member

@tommyp1ckles This PR depends on changes around the pkg/datapath modularization which were introduced during v1.15 development cycle and not backported to v1.14, I've marked the PR as backport/author for now so you can decide on what to do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/author The backport will be carried out by the author of the PR. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants