Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "node-map-max" to allow configuring nodemap size. #31407

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Add "node-map-max" to allow configuring nodemap size. #31407

merged 4 commits into from
Mar 26, 2024

Commits on Mar 22, 2024

  1. nodemap: add node-map-max flag to configure nodemap bpf size. 

    Using the node-map-max flag, one can now override the default 16k node map size.
This may be needed for large clusters, where the number of distinct node IPs in the cluster exceeds the standard size.

Also provides Size() to nodemap.Map interface such that loader can use this to set the NODE_MAP_MAX var while building bpf programs.

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
    @tommyp1ckles
    tommyp1ckles committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    6f33460 View commit details
    Browse the repository at this point in the history

  2. helm: add bpf.nodeMapMax helm val to configure node map size. 

    This can be used to override the default node-map-max value which sets bpf node map size.
In some cases, node map size may need to be overridden for very large clusters.

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
    @tommyp1ckles
    tommyp1ckles committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    caebb8f View commit details
    Browse the repository at this point in the history

  3. nodemap: add validation to check that node map max is at least 16384. 

    This is the constant default size prior to adding the flag.
There's not much reason to lower this value so to avoid edge cases we'll just say that this is the lower bound.

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
    @tommyp1ckles
    tommyp1ckles committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    66b777a View commit details
    Browse the repository at this point in the history

  4. docs: add section for scale implications of nodemap size. 

    With previous commits adding the ability to adjust nodemap size, this adds a section explaining the implications of the nodemap sizing.

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
    @tommyp1ckles
    tommyp1ckles committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    f09d7d0 View commit details
    Browse the repository at this point in the history