ci: Add step to place workflow_dispatch inputs in env #31424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
learnitall
added
area/CI
|
/test |
learnitall
added
dont-merge/preview-only
learnitall
force-pushed
the
pr/learnitall/echo-workflow-inputs
branch
from
55e606c
to
a256092
Compare
learnitall
force-pushed
the
pr/learnitall/echo-workflow-inputs
branch
from
a256092
to
1d10aec
Compare
pchaigno
approved these changes
Mar 27, 2024
brlbil
requested changes
Mar 27, 2024
learnitall
force-pushed
the
pr/learnitall/echo-workflow-inputs
branch
from
1d10aec
to
73a79ac
Compare
learnitall
force-pushed
the
pr/learnitall/echo-workflow-inputs
branch
from
73a79ac
to
422af3d
Compare
learnitall
force-pushed
the
pr/learnitall/echo-workflow-inputs
branch
from
422af3d
to
5cb9329
Compare
youngnick
approved these changes
Mar 27, 2024
|
/test |
brlbil
approved these changes
Mar 28, 2024
learnitall
removed
the
dont-merge/preview-only
learnitall
force-pushed
the
pr/learnitall/echo-workflow-inputs
branch
from
b59a5e2
to
383c14e
Compare
|
Well, my apologies folks. A sanity check was a good idea indeed. After trying out the job in a fork on I ran each modified workflow to verify the job works for each. In these runs, the workflows failed early due to the bad inputs that I provided to the workflow dispatch trigger (ie invalid context-ref) or due to missing variables in my fork. I've double-checked that the workflow failures are unrelated to the changes in this PR.
Thank you @julianwiedmann and @joestringer for pushing back and helping me learn a valuable lesson about testing, I appreciate it. |
learnitall
removed
the
dont-merge/preview-only
joestringer
approved these changes
Apr 4, 2024
learnitall
added a commit
to learnitall/cilium-ci-opensearch
that referenced
this pull request
May 6, 2024
This commit builds off of cilium/cilium#31424 by adding the ability to parse inputs that are echoed in the logs of workflow_dispatch triggered runs. This commit also performs some cleanup based on changes in previous commits. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
learnitall
added
needs-backport/1.13
|
Adding needs backport here. When we run scheduled workflows off of main through the Ariane Scheduled Workflows workflow, the workflow files from the target branch are used, not the workflow files from |
jibi
added
backport-pending/1.15
jibi
added
backport-pending/1.14
jibi
added
backport-pending/1.13
github-actions
bot
added
backport-done/1.15
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
This commit adds a new job to the beginning of workflows that have a workflow_dispatch trigger whose inputs provide important context to the run. The job saves the inputs to the environment so they can be viewed in the logs by users.
A majority of the workflows in the cilium repository have a workflow_dispatch trigger, which is used by users and Ariane to run workflows as needed. These workflows take a variety of inputs that may not always be made available in the logs, as they may not be used in a place that warrants their value being outputted. This obfuscation can make debugging these workflows difficult at times, as these inputs provide important context to the origin of the workflow's trigger.
For instance, the
PR-numberinput is used to determine the concurrency group for a workflow run. It is ignored everywhere else. The value of the concurrency group is not available via GitHub's UI or API, therefore this input obfuscated. However, thePR-numberinput provides valuable metadata, being used to describe the branch or PR that a workflow was triggered for.This commit modifies workflows which have non-obvious workflow_dispatch input values
Fixes: #31207