v1.15 Backports 2024-05-13 #32500
Merged
v1.15 Backports 2024-05-13 #32500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 77cafec ] This commit adds a new job to the beginning of workflows that have a workflow_dispatch trigger whose inputs provide important context to the run. The job echos the inputs so they can be viewed in the logs by users. A majority of the workflows in the cilium repository have a workflow_dispatch trigger, which is used by users and Ariane to run workflows as needed. These workflows take a variety of inputs that may not always be made available in the logs, as they may not be used in a place that warrants their value being outputted. This obfuscation can make debugging these workflows difficult at times, as these inputs provide important context to the origin of the workflow's trigger. For instance, the `PR-number` input is used to determine the concurrency group for a workflow run. It is ignored everywhere else. The value of the concurrency group is not available via GitHub's UI or API, therefore this input obfuscated. However, the `PR-number` input provides valuable metadata, being used to describe the branch or PR that a workflow was triggered for. Fixes: #31207 Signed-off-by: Ryan Drew <ryan.drew@isovalent.com> Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit 96c2eb8 ] [ backporter's notes: trivial conflict in pkg/option/config.go ] It doesn't make sense to configure it to a negative value. Hence, let's just enforce it at the flags level by converting it to a uint type. This change is not expected to have backward-incompatible effects given that it was already supposed to be a non-negative value. Additionally, negative values would be automatically rejected during flags validation, hence preventing a silent fallback to high positive values due to unexpected conversions. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com> Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit 0836539 ] Extend the clustermesh-apiserver/kvstoremesh configurations by adding the previously missed kvstore-max-consecutive-quorum-errors option to match the one already provided by the Cilium agents, as well as configure the same default value. Fixes: 2911b44 ("kvstore: add a cell for the kvstore client") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com> Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit 3d1efae ] Signed-off-by: Joe Stringer <joe@cilium.io> Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit 3f5e735 ] This commit adds validation for `commit_status_start` job. This job is used in workflows that is triggered by Ariane to set the run status to pending. Ariane is going to depend on this job being existed and its name is "Commit Status Start". Also, the trigger syntax of `link-build-commits.yaml` is changed because `yq` is throwing an error. Signed-off-by: Birol Bilgin <birol@cilium.io> Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi
added
kind/backports
jibi
requested review from
joestringer,
michi-covalent,
brlbil,
learnitall and
giorio94
|
/test-backport-1.15 |
giorio94
approved these changes
May 13, 2024
brlbil
approved these changes
May 13, 2024
michi-covalent
approved these changes
May 13, 2024
joestringer
approved these changes
May 13, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, a GitHub action will update the labels of these PRs: