Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpv1: Local internalTrafficPolicy support for ClusterIP advertisements #31442

Merged
merged 2 commits into from
Mar 25, 2024

Commits on Mar 22, 2024

  1. bgpv1: Local internalTrafficPolicy support for ClusterIP advertisements

    Fixes: cilium#31389
    
    As the ClusterIP services can have .spec.internalTrafficPolicy set to Local, advertising a ClusterIP from a node which has no local endpoints may cause unreachability of the advertised service if the traffic is routed to that node.
    
    So if .spec.internalTrafficPolicy of a service is set to Local, advertise its ClusterIP over BGP only if it has non-zero local endpoints.
    
    Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
    chaunceyjiang committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e6278be View commit details
    Browse the repository at this point in the history
  2. bgpv1: Add the documentation for using serviceAdvertisements

    Ideally, the internalTrafficPolicy and externalTrafficPolicy fields are independent. However, since we advertise the ClusterIP to the external world via BGP, it has caused some confusion regarding the meanings of external and internal. Therefore, we need to provide some clarification in the documentation.
    
    For ClusterIP: Only consider the iTP configuration for advertisement, and ignore the eTP configuration.
    For ExternalIP and LBIP: Only consider the eTP configuration for advertisement, and ignore the iTP configuration.
    
    Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
    chaunceyjiang committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    eba6b29 View commit details
    Browse the repository at this point in the history