Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CiliumOperatorName constant #31597

Merged
merged 1 commit into from
May 2, 2024
Merged

Remove CiliumOperatorName constant #31597

merged 1 commit into from
May 2, 2024

Conversation

miono
Copy link
Contributor

@miono miono commented Mar 25, 2024

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

@miono miono requested a review from a team as a code owner March 25, 2024 20:46
@miono miono requested a review from thorn3r March 25, 2024 20:46
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 25, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 25, 2024
thorn3r
thorn3r reviewed Mar 29, 2024
View reviewed changes
Copy link
Contributor

@thorn3r thorn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! It looks like there are no longer any references to this constant. I think we can just remove it rather than correcting the typo.

@miono
Copy link
Contributor Author

miono commented Apr 4, 2024

I've amended my commit to do that instead!

@miono miono requested a review from thorn3r April 4, 2024 07:10
@thorn3r thorn3r added the release-note/misc This PR makes changes that have no direct user impact. label Apr 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 4, 2024
thorn3r
thorn3r approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@thorn3r thorn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thorn3r
Copy link
Contributor

thorn3r commented Apr 4, 2024

/test

@lmb lmb changed the title Fix spelling of CiliumOperatorName Remove CiliumOperatorName constant Apr 17, 2024
@lmb
Copy link
Contributor

lmb commented Apr 17, 2024

/test

@miono
Copy link
Contributor Author

miono commented Apr 18, 2024

Do you need me to rebase maybe, or why are the tests failing?

@thorn3r
Copy link
Contributor

thorn3r commented Apr 22, 2024

Hey @miono yes please rebase and I'll retrigger the tests. The clustermesh related failures are caused by the changes in this PR. The workflow runs on main and this branch is missing the needed changes.

@miono
Copy link
Contributor Author

miono commented Apr 23, 2024

@thorn3r Rebased on main!

@thorn3r
Copy link
Contributor

thorn3r commented Apr 23, 2024

/test

1 similar comment
@youngnick
Copy link
Contributor

/test

@miono @aanm
Remove CiliumOperatorName constant
8d6671b 
There are no longer any references to this constant so we should be able
to remove it.

Signed-off-by: Markus Nilsson <markus.nilsson@yubico.com>
@aanm aanm force-pushed the fix-spelling-of-operator branch from 5862590 to 8d6671b Compare May 2, 2024 09:08
@aanm
Copy link
Member

aanm commented May 2, 2024

/test

@aanm aanm enabled auto-merge May 2, 2024 09:08
@aanm aanm added this pull request to the merge queue May 2, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 2, 2024
Merged via the queue into cilium:main with commit 962e78d May 2, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miono @thorn3r @lmb @youngnick @aanm