Add support for multiple clustermesh-apiserver replicas (ClusterMesh HA) #31677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/test |
thorn3r
force-pushed
the
pr/thorn3r/clustermeshHA
branch
from
0ea2d4e
to
b855a05
Compare
|
/test |
thorn3r
force-pushed
the
pr/thorn3r/clustermeshHA
branch
from
b855a05
to
660dc0f
Compare
thorn3r
added
the
release-note/major
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
Closed
thorn3r
added
release-note/minor
thorn3r
changed the title
This was referenced Apr 3, 2024
giorio94
reviewed
Apr 4, 2024
thorn3r
force-pushed
the
pr/thorn3r/clustermeshHA
branch
from
660dc0f
to
ee4fb0a
Compare
|
/test |
|
/test |
Update the clustermesh-upgrade CI workflow to test rolling- upgrades/failover by setting maxSurge=1 and maxUnavailable=0 and adding a new test using a global service. The test restarts the clustermesh-apiserver deployment on cluster2 and deploys a global service to both clusters. Cluster1 should be able to properly handle the failover event, establish a connection with the new clustermesh-apiserver pods, and synchronize the endpoints from cluster2 for the service. To ensure ClusterMesh both with and without KVStoreMesh enabled can handle failover events, separate upgrading Cilium and enabling KVStoreMesh for cluster1 into separate steps. Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
thorn3r
force-pushed
the
pr/thorn3r/clustermeshHA
branch
from
571dc26
to
bbf4488
Compare
|
/ci-clustermesh |
|
/test |
|
TIL that comments in a multi-line command in bash are tricky |
Yep, I typically just add them above the entire command, to avoid these kinds of problems. |
squeed
approved these changes
Apr 8, 2024
viktor-kurchenko
approved these changes
Apr 8, 2024
joamaki
approved these changes
Apr 9, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
marseel
added
needs-backport/1.15
|
Marking for backport to v1.15 to address #30964. I'm going to backport a reduced version which only includes the configuration of the unique etcd Cluster ID and the interceptor logic, fixing a bug potentially causing Cilium agents to incorrectly restart an etcd watch against a different clustermesh-apiserver instance. |
giorio94
added
the
needs-backport/1.15
giorio94
added
backport-pending/1.15
8 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for running clustermesh-apiserver deployments with multiple replicas for high availability.
Each clustermesh-apiserver pod runs its own etcd cluster. Depending on configuration, either the Cilium Agent or KVStoreMesh instance watches etcd in a remote cluster. All responses from the remote etcd cluster are intercepted and the header is inspected to retrieve the etcd cluster ID. If a failover event occurs and the cluster ID has changed, the remote connection is restarted to ensure that no events are missed and that no invalid data is retained. See individual commit messages for additional details.