k8s: Add support for Kubernetes 1.30.0

[christarazi]

Update to k8s 1.30.0 and fix code-generator scripts.

Also, bump sigs.k8s.io/controller-runtime to the latest main version as
of this commit (v0.17.1-0.20240327193027-21368602d84b) to workaround a
breaking change introduced in 1.30 libraries.

Co-authored-by: André Martins andre@cilium.io
Signed-off-by: Chris Tarazi chris@isovalent.com

[christarazi]

/test

[christarazi]

@tklauser @jschwinger233, could I get your sign off here?

[joestringer]

Some minor nits and observations from the Make target pieces. I feel like the make targets we have here are fighting with the upstream k8s codegen tooling a bit. Non-blocking feedback, we can iterate further in-tree.

[joestringer]

Are these errors printed in the (passing) Generate k8s API CI workflow a problem?

contrib/scripts/k8s-code-gen.sh "/tmp/cilium.tmphCFo2Q9B"
SCRIPT_ROOT=/home/runner/work/cilium/cilium/src/github.com/cilium/cilium/contrib/scripts/../..
Generating client code for 4 targets
grep: /tmp/cilium.tmphCFo2Q9B/github.com/cilium/cilium/pkg/k8s/slim/k8s/client/clientset: No such file or directory
Generating lister code for 4 targets
grep: /tmp/cilium.tmphCFo2Q9B/github.com/cilium/cilium/pkg/k8s/slim/k8s/client/listers: No such file or directory
Generating informer code for 4 targets
grep: /tmp/cilium.tmphCFo2Q9B/github.com/cilium/cilium/pkg/k8s/slim/k8s/client/informers: No such file or directory
Generating client code for 1 targets
grep: /tmp/cilium.tmphCFo2Q9B/github.com/cilium/cilium/pkg/k8s/slim/k8s/apiextensions-client/clientset: No such file or directory
Generating lister code for 1 targets
grep: /tmp/cilium.tmphCFo2Q9B/github.com/cilium/cilium/pkg/k8s/slim/k8s/apiextensions-client/listers: No such file or directory
Generating informer code for 1 targets
grep: /tmp/cilium.tmphCFo2Q9B/github.com/cilium/cilium/pkg/k8s/slim/k8s/apiextensions-client/informers: No such file or directory
Generating client code for 2 targets
grep: /tmp/cilium.tmphCFo2Q9B/github.com/cilium/cilium/pkg/k8s/client/clientset: No such file or directory
Generating lister code for 2 targets
grep: /tmp/cilium.tmphCFo2Q9B/github.com/cilium/cilium/pkg/k8s/client/listers: No such file or directory
Generating informer code for 2 targets
grep: /tmp/cilium.tmphCFo2Q9B/github.com/cilium/cilium/pkg/k8s/client/informers: No such file or directory

[christarazi]

@joestringer From my understanding, these errors are expected. I analyszed the exectuion of the script using set -x and traced it down to the following snippet:

    ( kube::codegen::internal::grep -l --null \
        -e '^// Code generated by client-gen. DO NOT EDIT.$' \
        -r "${out_dir}/${clientset_subdir}" \
        --include '*.go' \
        || true \
    ) | xargs -0 rm -f

It seems to me that this snippet is trying to find any files under "${out_dir}/${clientset_subdir}" as long as they match the regex string, then delete them, hence the xargs rm pipe. Notice the true at the end of the grep command, which suggests that the overall script should not fail if the grep fails, presumably if the path does not exist. However, the path is not expected to exist because the subsequent step after the snippet above is to generate the code. In other words, this snippet is to remove any leftover files before beginning the code generation. These errors are expected in summary.

We did not see these errors prior to this PR because we did not directly use this script.

[aanm]

@christarazi needs rebase

[christarazi]

/test

Edit:

• CI: Conformance Ginkgo: E2E Test (1.29, f06-agent-policy-basic): "unable to queue endpoint build" #31827
• CI: Conformance E2E: client-egress-l7-named-port/pod-to-pod: command terminated with exit code 28 (timeout) #27762

[christarazi]

Updated to final v1.30.0 from the rc.1. No changes in the slim structures as well.

[christarazi]

/test

Edit:

• CI: Conformance E2E: client-egress-l7-named-port/pod-to-pod: command terminated with exit code 28 (timeout) #27762

[ysksuzuki]

CEGP CRD change looks good to me