Makefile: Run generate-k8s-api in builder image #32063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
the
release-note/misc
|
/test |
|
Conflicts with #31687 |
joestringer
force-pushed
the
pr/joe/dockerize-k8s-api-gen
branch
from
24b44da
to
aa03360
Compare
|
/test |
christarazi
force-pushed
the
pr/christarazi/k8s-1.30
branch
from
ac391c4
to
ae6c2a1
Compare
joestringer
force-pushed
the
pr/joe/dockerize-k8s-api-gen
branch
from
aa03360
to
7e0635f
Compare
christarazi
force-pushed
the
pr/christarazi/k8s-1.30
branch
2 times, most recently
from
69100fe
to
7c0faf9
Compare
joestringer
removed
the
dont-merge/blocked
By default, run the 'make generate-k8s-api' target inside the Cilium builder image to ensure that the correct version of protoc is used to generate the code. Suggested-by: Robin Hahling <robin.hahling@gw-computing.net> Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
pr/joe/dockerize-k8s-api-gen
branch
from
7e0635f
to
ae650e5
Compare
|
/test |
viktor-kurchenko
approved these changes
Apr 26, 2024
aanm
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: #31687
By default, run the
make generate-k8s-apitarget inside the Cilium builder image to ensure that the correct version ofprotocis used to generate the code.Suggested-by: @rolinh