service: Update for L7 LB while locked #31744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
kind/bug
jrajahalme
added
the
backport/author
|
Labeled for author backport due to recent churn in the affected code. |
|
/test |
Keep service manager locked while reupserting services after L7 LB redirection updates. This removes the race where a service would be re-upserted while having been (concurrently) removed. Fixes: cilium#18894 Reported-by: Jussi Maki <joamaki@isovalent.com> Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
l7-lb-service-lock
branch
from
af14436
to
5c01103
Compare
|
/test |
mhofstetter
approved these changes
Apr 5, 2024
|
This PR is linked to #18894, but I can't find the report for the problem this PR fixes. Could you give me a pointer to the report? |
#18894 introduced the racy code that is fixed here. Original code gets copy of a service and then adds it again to account for the changes in L7 LB service registrations. The problem is that this was done without holding a lock, making it possible that service that has been removed after the copy was created is erroneously added back. |
|
I see. Thanks for the explanation! |
maintainer-s-little-helper
bot
added
the
ready-to-merge
1 task
jrajahalme
added
backport-pending/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.4
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.4
1 task
jrajahalme
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.10
1 task
jrajahalme
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.15
github-actions
bot
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.10
github-actions
bot
added
backport-done/1.13
github-actions
bot
added
backport-done/1.15
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep service manager locked while updating services after L7 LB redirection updates. This removes the race where a service would be re-upserted while having been (concurrently) removed.
Fixes: #18894
Reported-by: Jussi Maki joamaki@isovalent.com