Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.13] service: Update for L7 LB while locked #31862

Merged
merged 1 commit into from Apr 11, 2024
Merged

[v1.13] service: Update for L7 LB while locked #31862

merged 1 commit into from Apr 11, 2024

Conversation

jrajahalme
Copy link
Member

Once this PR is merged, a GitHub action will update the labels of these PRs:

31744

@jrajahalme
service: Update for L7 LB while locked
2618643 
[ upstream commit d913b62 ]

Keep service manager locked while reupserting services after L7 LB
redirection updates. This removes the race where a service would be
re-upserted while having been (concurrently) removed.

Fixes: cilium#18894

Reported-by: Jussi Maki <joamaki@isovalent.com>
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme added kind/backports This PR provides functionality previously merged into master. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels Apr 9, 2024
@jrajahalme jrajahalme requested a review from a team as a code owner April 9, 2024 12:29
@jrajahalme jrajahalme changed the title service: Update for L7 LB while locked [v1.13] service: Update for L7 LB while locked Apr 9, 2024
@jrajahalme
Copy link
Member Author

jrajahalme commented Apr 9, 2024 •
edited by maintainer-s-little-helper bot

/test-backport-1.13

Job 'Cilium-PR-K8s-1.22-kernel-4.19' hit: #30802 (92.21% similarity)

Job 'Cilium-PR-K8s-1.21-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathVerifier Runs the kernel verifier against Cilium's BPF datapath

Failure Output

FAIL: test-verifier pod not ready after timeout

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.19/480/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.21-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request Apr 9, 2024
Open
@lmb
Copy link
Contributor

lmb commented Apr 10, 2024

/test-1.21-4.19

@lmb
Copy link
Contributor

lmb commented Apr 10, 2024

/test-1.22-4.19

@lmb
Copy link
Contributor

lmb commented Apr 10, 2024

/test-1.24-4.19

@lmb
Copy link
Contributor

lmb commented Apr 10, 2024

/test-1.24-5.4

lmb
lmb approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tophat

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 11, 2024
@lmb lmb merged commit 33c7352 into cilium:v1.13 Apr 11, 2024
62 checks passed
This was referenced Apr 11, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmb lmb lmb approved these changes

Assignees
No one assigned
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrajahalme @lmb