Improve dev-doctor version detection and error reporting #32035
Conversation
Various commands were specifying custom version regexes for the match. It's easier to just declare one fairly loose version matcher and then append it in all the relevant binaryCheck declarations. Signed-off-by: Joe Stringer <joe@cilium.io>
Previously if the command failed, it would only output something like "exit status 1" and not include the actual output of the command. Include the command output to improved debuggability. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
the
release-note/misc
|
/test |
Sorry, my comment is a bit unrelated to the PR but based on the above I wanted to ask: why do we require protoc to be installed locally? In my experience, different protoc versions may generate different code. To address this issue when generating the Hubble API, we use a the cilium-builder image that includes protoc (and a set of protoc plugins). Couldn't such approach be used for |
|
@rolinh Ah, I didn't know that protoc was sensitive to the specific version being used, thanks for pointing that out. I just found that I didn't have protoc installed and I needed it in order to generate some code. Maybe the solution to that problem is actually to just dockerize. Let me poke around and see if there's some reason we aren't doing that. |
joestringer
force-pushed
the
pr/joe/dev-doctor-20240417
branch
from
4945a62
to
f490223
Compare
|
Alright, I spun up #32063 as a replacement for that part. The other cleanups in this PR could be independently useful though, so I'll re-mark this for review just as a cleanup PR. |
joestringer
changed the title
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Improve some dev-doctor debugging output and standardize the version check to use the same regex to match versions for various different commands.
Tested locally using
make dev-doctor, works well for my environment.