-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple CiliumEndpointSlice controller from operator Clientset #32353
Conversation
25f65e7
to
51db531
Compare
/test |
found a real CI failure, putting back into draft until I apply a fix |
51db531
to
4c6e4d4
Compare
/test |
4c6e4d4
to
1856f82
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
I've just left a non-blocking suggestion inline, feel free to ignore it if you prefer the current approach for the error handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
1856f82
to
d0ee2a7
Compare
Add ClientBuilderCell to Cilium Operator's client package, which provides a ClientBuilderFunc that can be used to create a new Clientset for a controller. This allows decoupling the various controllers from the main Clientset used by the operator. Additionally, add support for optionally specifying a user agent when creating a new Clientset. Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
d0ee2a7
to
d7abb44
Compare
Create a new Clientset for the CiliumEndpointSlice controller using the ClientBuilderFunc to decouple it from the other controllers. Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
d7abb44
to
88933c2
Compare
/test |
Decouple the CiliumEndpointSlice controller from the main operator Clientset to prevent it from saturating the rate limit and affecting other controllers.
The 1st commit introduces a new Hive Cell to provide a
ClientBuilderFunc
, which can be executed by a controller to retrieve a new Clientset. The 2nd commit utilizes theClientBuilderFunc
in the CiliumEndpointSlice controller to create a new Clientset