-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add job name validation #32462
Merged
julianwiedmann
merged 1 commit into
main
from
pr/brlbil/add_commit_status_start_validation
May 13, 2024
Merged
CI: Add job name validation #32462
julianwiedmann
merged 1 commit into
main
from
pr/brlbil/add_commit_status_start_validation
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds validation for `commit_status_start` job. This job is used in workflows that is triggered by Ariane to set the run status to pending. Ariane is going to depend on this job being existed and its name is "Commit Status Start". Also, the trigger syntax of `link-build-commits.yaml` is changed because `yq` is throwing an error. Signed-off-by: Birol Bilgin <birol@cilium.io>
/test |
/test |
|
/test |
1 similar comment
/test |
Sorry for the noise I am trying to find the issue with the not-triggered workflow. |
/test |
christarazi
approved these changes
May 10, 2024
viktor-kurchenko
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation for
commit_status_start
job. This job is used in workflows that is triggered by Ariane to set the run status to pending. Ariane is going to depend on this job being existed and its name is "Commit Status Start". So we are adding this check to make sure.Also, the trigger syntax of
link-build-commits.yaml
is changed becauseyq
is throwing an error.