Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: Separate state directory inside runtime directory #537

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Apr 11, 2017

Moves all endpoint state into the state/ subdirectory inside the
existing runtime directory. This allows to establish different
permissions for the default runtime directory which can be mounted
into container images and the actual state which must be protected.

Allows moving cilium.sock back into the runtime directory for easy
sharing in and out of containers.

Signed-off-by: Thomas Graf thomas@cilium.io

Moves all endpoint state into the state/ subdirectory inside the
existing runtime directory. This allows to establish different
permissions for the default runtime directory which can be mounted
into container images and the actual state which must be protected.

Allows moving cilium.sock back into the runtime directory for easy
sharing in and out of containers.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf added kind/bug This is a bug in the Cilium logic. kind/enhancement This would improve or streamline existing functionality. stable candidate labels Apr 11, 2017
@tgraf tgraf requested review from aalemayhu and aanm April 11, 2017 14:29
Copy link
Contributor

@aalemayhu aalemayhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, +1 for fixing comment warnings.

Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes but I have mix feelings regarding the stable candidate. Changing the path of a socket is considered a minor or a `patch?

@tgraf
Copy link
Member Author

tgraf commented Apr 11, 2017

I agree with the changes but I have mix feelings regarding the stable candidate. Changing the path of a socket is considered a minor or a `patch?

I'm fine holding off on the stable backport. I'd favour a soonish 0.9 release then so we can have a single Vagrantfile that works with our stable container images.

@tgraf tgraf merged commit 880f9cc into master Apr 11, 2017
@tgraf tgraf deleted the state-dir branch April 11, 2017 18:56
@tgraf tgraf mentioned this pull request Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is a bug in the Cilium logic. kind/enhancement This would improve or streamline existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants