Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: fix k8s GetLabels if response is nil #567

Merged
merged 1 commit into from
Apr 17, 2017
Merged

daemon: fix k8s GetLabels if response is nil #567

merged 1 commit into from
Apr 17, 2017

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 17, 2017

Signed-off-by: André Martins andre@cilium.io

@aanm
daemon: fix k8s GetLabels if response is nil
e99435b 
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added kind/bug This is a bug in the Cilium logic. stable candidate labels Apr 17, 2017
ianvernon
ianvernon approved these changes Apr 17, 2017
View reviewed changes
Copy link
Member

@ianvernon ianvernon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

aalemayhu
aalemayhu suggested changes Apr 17, 2017
View reviewed changes
Copy link
Contributor

@aalemayhu aalemayhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please extend your commit notes to include commands for testing this or mention how you tested it. Thanks.

@tgraf tgraf merged commit a355c3b into master Apr 17, 2017
@tgraf tgraf deleted the fixing-k8s-missing-labels branch April 17, 2017 23:36
@aanm aanm restored the fixing-k8s-missing-labels branch April 18, 2017 00:00
@aanm aanm deleted the fixing-k8s-missing-labels branch April 18, 2017 00:01
@aanm aanm restored the fixing-k8s-missing-labels branch April 18, 2017 00:01
@aanm aanm deleted the fixing-k8s-missing-labels branch April 18, 2017 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalemayhu aalemayhu aalemayhu requested changes

@tgraf tgraf tgraf approved these changes

@ianvernon ianvernon ianvernon approved these changes

Assignees
No one assigned
Labels
kind/bug This is a bug in the Cilium logic.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanm @aalemayhu @tgraf @ianvernon