all: switch from package syscall to x/sys/unix #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syscall package is locked down and the comment in [1] advises to switch code to use the corresponding package from golang.org/x/sys. Do so and replace usage of package syscall with package golang.org/x/sys/unix. This will also allow to get updates and fixes without having to use a new go version. [1] https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
aanm
approved these changes
Apr 21, 2017
|
Thanks @tklauser! |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Aug 3, 2017
Automatic merge from submit-queue Switch from package syscall to golang.org/x/sys/unix **What this PR does / why we need it**: The syscall package is locked down and the comment in https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 advises to switch code to use the corresponding package from golang.org/x/sys. This PR does so and replaces usage of package syscall with package golang.org/x/sys/unix where applicable. This will also allow to get updates and fixes without having to use a new go version. In order to get the latest functionality, golang.org/x/sys/ is re-vendored. This also allows to use Eventfd() from this package instead of calling the eventfd() C function. **Special notes for your reviewer**: This follows previous works in other Go projects, see e.g. moby/moby#33399, cilium/cilium#588 **Release note**: ```release-note NONE ```
wgliang
pushed a commit
to wgliang/utils
that referenced
this pull request
Jun 11, 2018
Automatic merge from submit-queue Switch from package syscall to golang.org/x/sys/unix **What this PR does / why we need it**: The syscall package is locked down and the comment in https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 advises to switch code to use the corresponding package from golang.org/x/sys. This PR does so and replaces usage of package syscall with package golang.org/x/sys/unix where applicable. This will also allow to get updates and fixes without having to use a new go version. In order to get the latest functionality, golang.org/x/sys/ is re-vendored. This also allows to use Eventfd() from this package instead of calling the eventfd() C function. **Special notes for your reviewer**: This follows previous works in other Go projects, see e.g. moby/moby#33399, cilium/cilium#588 **Release note**: ```release-note NONE ```
tamalsaha
pushed a commit
to kmodules/shared-informer
that referenced
this pull request
Aug 13, 2020
Automatic merge from submit-queue Switch from package syscall to golang.org/x/sys/unix **What this PR does / why we need it**: The syscall package is locked down and the comment in https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 advises to switch code to use the corresponding package from golang.org/x/sys. This PR does so and replaces usage of package syscall with package golang.org/x/sys/unix where applicable. This will also allow to get updates and fixes without having to use a new go version. In order to get the latest functionality, golang.org/x/sys/ is re-vendored. This also allows to use Eventfd() from this package instead of calling the eventfd() C function. **Special notes for your reviewer**: This follows previous works in other Go projects, see e.g. moby/moby#33399, cilium/cilium#588 **Release note**: ```release-note NONE ``` Kubernetes-commit: 5d24a2c19923d6da46110b827619f4b21cf689ac
tamalsaha
pushed a commit
to gomodules/jsonpath
that referenced
this pull request
Apr 21, 2021
Automatic merge from submit-queue Switch from package syscall to golang.org/x/sys/unix **What this PR does / why we need it**: The syscall package is locked down and the comment in https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 advises to switch code to use the corresponding package from golang.org/x/sys. This PR does so and replaces usage of package syscall with package golang.org/x/sys/unix where applicable. This will also allow to get updates and fixes without having to use a new go version. In order to get the latest functionality, golang.org/x/sys/ is re-vendored. This also allows to use Eventfd() from this package instead of calling the eventfd() C function. **Special notes for your reviewer**: This follows previous works in other Go projects, see e.g. moby/moby#33399, cilium/cilium#588 **Release note**: ```release-note NONE ``` Kubernetes-commit: 5d24a2c19923d6da46110b827619f4b21cf689ac
tamalsaha
pushed a commit
to gomodules/jsonpath
that referenced
this pull request
Apr 21, 2021
Automatic merge from submit-queue Switch from package syscall to golang.org/x/sys/unix **What this PR does / why we need it**: The syscall package is locked down and the comment in https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 advises to switch code to use the corresponding package from golang.org/x/sys. This PR does so and replaces usage of package syscall with package golang.org/x/sys/unix where applicable. This will also allow to get updates and fixes without having to use a new go version. In order to get the latest functionality, golang.org/x/sys/ is re-vendored. This also allows to use Eventfd() from this package instead of calling the eventfd() C function. **Special notes for your reviewer**: This follows previous works in other Go projects, see e.g. moby/moby#33399, cilium/cilium#588 **Release note**: ```release-note NONE ``` Kubernetes-commit: 5d24a2c19923d6da46110b827619f4b21cf689ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syscall package is locked down and the comment in [1] advises to
switch code to use the corresponding package from golang.org/x/sys. Do
so and replace usage of package syscall with package
golang.org/x/sys/unix. This will also allow to get updates and fixes
without having to use a new go version.
[1] https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24