bpf: fix empty map check condition #6164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without the fix: linux-436c:/sys/fs/bpf/tc/globals # cilium map get panic: runtime error: index out of range goroutine 1 [running]: github.com/cilium/cilium/cilium/cmd.glob..func33(0x22a8b20, 0x2852118, 0x0, 0x0) /home/nirmoy/go/src/github.com/cilium/cilium/cilium/cmd/map_get.go:42 +0x2d2 github.com/cilium/cilium/vendor/github.com/spf13/cobra.(*Command).execute(0x22a8b20, 0x2852118, 0x0, 0x0, 0x22a8b20, 0x2852118) /home/nirmoy/go/src/github.com/cilium/cilium/vendor/github.com/spf13/cobra/command.go:648 +0x234 github.com/cilium/cilium/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x22ac040, 0x22abe20, 0xc421635f20, 0x1) /home/nirmoy/go/src/github.com/cilium/cilium/vendor/github.com/spf13/cobra/command.go:735 +0x2d4 github.com/cilium/cilium/vendor/github.com/spf13/cobra.(*Command).Execute(0x22ac040, 0xc4200ac058, 0x0) /home/nirmoy/go/src/github.com/cilium/cilium/vendor/github.com/spf13/cobra/command.go:693 +0x2b github.com/cilium/cilium/cilium/cmd.Execute() /home/nirmoy/go/src/github.com/cilium/cilium/cilium/cmd/root.go:46 +0x2d main.main() /home/nirmoy/go/src/github.com/cilium/cilium/cilium/main.go:20 +0x20 Signed-off-by: Nirmoy Das <ndas@suse.de>
ianvernon
approved these changes
Nov 4, 2018
|
test-me-please |
tgraf
approved these changes
Nov 4, 2018
tgraf
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without the fix:
linux-436c:/sys/fs/bpf/tc/globals # cilium map get
panic: runtime error: index out of range
goroutine 1 [running]:
github.com/cilium/cilium/cilium/cmd.glob..func33(0x22a8b20, 0x2852118, 0x0, 0x0)
/home/nirmoy/go/src/github.com/cilium/cilium/cilium/cmd/map_get.go:42 +0x2d2
github.com/cilium/cilium/vendor/github.com/spf13/cobra.(*Command).execute(0x22a8b20, 0x2852118, 0x0, 0x0, 0x22a8b20, 0x2852118)
/home/nirmoy/go/src/github.com/cilium/cilium/vendor/github.com/spf13/cobra/command.go:648 +0x234
github.com/cilium/cilium/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x22ac040, 0x22abe20, 0xc421635f20, 0x1)
/home/nirmoy/go/src/github.com/cilium/cilium/vendor/github.com/spf13/cobra/command.go:735 +0x2d4
github.com/cilium/cilium/vendor/github.com/spf13/cobra.(*Command).Execute(0x22ac040, 0xc4200ac058, 0x0)
/home/nirmoy/go/src/github.com/cilium/cilium/vendor/github.com/spf13/cobra/command.go:693 +0x2b
github.com/cilium/cilium/cilium/cmd.Execute()
/home/nirmoy/go/src/github.com/cilium/cilium/cilium/cmd/root.go:46 +0x2d
main.main()
/home/nirmoy/go/src/github.com/cilium/cilium/cilium/main.go:20 +0x20
Signed-off-by: Nirmoy Das ndas@suse.de
This change is