vendor: Switch from dep to Go 1.11 modules #6232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.11 introduces the feature of modules which allow to develop Go programs without GOPATH and fetch versioned Go dependencies. The long term intention of Go modules is to stop using `vendor/` dir, although it can optionally still exist. This change leaves the `vendor/` dir for developers who still want to use GOPATH and for offline builds. Signed-off-by: Michal Rostecki <mrostecki@suse.de>
|
test-me-please |
aanm
requested changes
Nov 13, 2018
There was a problem hiding this comment.
@mrostecki I hope you didn't spend too much time with this. Unfortunately go modules are not well suited as they are right now as they rely that all golang projects to make use of semver so we can't easily correlate with kubernetes version we are using.
More info:
#5367 (comment)
|
@aanm I didn't spend much time on it. Good point, I completely missed the fact that k8s versions are not processed correctly. I will put it on hold till Go 1.12. golang/go#25898 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.11 introduces the feature of modules which allow to develop
Go programs without GOPATH and fetch versioned Go dependencies.
The long term intention of Go modules is to stop using
vendor/dir, although it can optionally still exist. This change leaves
the
vendor/dir for developers who still want to use GOPATHand for offline builds.
Signed-off-by: Michal Rostecki mrostecki@suse.de
This change is