Kubernetes NetworkPolicy fixes & enhancements #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to isolate all Kubernetes specific code in this package over time. Signed-off-by: Thomas Graf <thomas@cilium.io>
New LabelArray type with Contains() function to implement functionality to require multiple labels as a set. Signed-off-by: Thomas Graf <thomas@cilium.io>
Modifies the AllowRule to take a set of labels which are required to be present. Backwards compatibility is maintained, if a single label is provided, it will be converted into a set containing a single label. Signed-off-by: Thomas Graf <thomas@cilium.io>
Fix NetworkPolicy implementation to correctly handle the matchLabels by requiring all labels. Adds a unit test to verify the behaviour. Signed-off-by: Thomas Graf <thomas@cilium.io>
// List of sources which should be able to access the pods selected for this rule. // Items in this list are combined using a logical OR operation. // If this field is empty or missing, this rule matches all sources (traffic not restricted by source). // If this field is present and contains at least on item, this rule allows traffic only if the // traffic matches at least one item in the from list. // +optional From []NetworkPolicyPeer Signed-off-by: Thomas Graf <thomas@cilium.io>
Supports v1beta1.NetworkPolicyPort as part of NetworkPolicy and converts it into ingress RuleL4 rules. Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
added
kind/bug
aanm
approved these changes
May 2, 2017
ianvernon
reviewed
May 2, 2017
| type ConsumableDecision byte | ||
|
|
||
| const ( | ||
| // UNDECIDED means unsed while the decision is still undecided |
There was a problem hiding this comment.
unsed? undecided about what? please clarify in the comment.
There was a problem hiding this comment.
Undecided means that the policy decision has not been made yet. I haven't introduced this code in this commit, I've just moved it into a separate package.
ianvernon
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.