Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict ENI usage to IPv4 #8843

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Restrict ENI usage to IPv4 #8843

merged 3 commits into from
Aug 8, 2019

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Aug 8, 2019 •
edited
Loading

This change is Reviewable

@tgraf tgraf added the kind/bug This is a bug in the Cilium logic. label Aug 8, 2019
@tgraf tgraf requested a review from a team August 8, 2019 14:18
@coveralls
Copy link

coveralls commented Aug 8, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 44.196% when pulling 6de30df on pr/tgraf/eni-ipv6 into ac46a9d on master.

@tgraf
Copy link
Member Author

tgraf commented Aug 8, 2019

test-me-please

@tgraf
ipam: Fix error strong when router IP is not available
3ee0f3f 
The error is returned for all address families, the existing gives a wrong
indication that the IPv4 router IP cannot be allocated.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
option: Prohibit enabling ENI and IPv6 at the same time
4ab728b 
Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
doc: Document AWS ENI integration limitations
6de30df 
Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf requested a review from a team as a code owner August 8, 2019 19:53
@tgraf tgraf added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. pending-review labels Aug 8, 2019
@tgraf
Copy link
Member Author

tgraf commented Aug 8, 2019

test-me-please

@tgraf tgraf merged commit 24961d9 into master Aug 8, 2019
@tgraf tgraf deleted the pr/tgraf/eni-ipv6 branch August 8, 2019 23:33
@aanm aanm added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianvernon ianvernon ianvernon approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/bug This is a bug in the Cilium logic. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tgraf @coveralls @ianvernon @aanm