Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endpoint: move deletion deadlock unit test to pkg/endpoint #9067

Merged
merged 2 commits into from
Aug 29, 2019

Conversation

ianvernon
Copy link
Member

@ianvernon ianvernon commented Aug 28, 2019

Signed-off by: Ian Vernon ian@cilium.io


This change is Reviewable

@ianvernon ianvernon added pending-review kind/cleanup This includes no functional changes. labels Aug 28, 2019
@ianvernon ianvernon requested review from a team August 28, 2019 18:54
@ianvernon ianvernon requested a review from a team as a code owner August 28, 2019 18:54
@ianvernon
Copy link
Member Author

test-me-please

Ian Vernon added 2 commits August 28, 2019 13:31
Signed-off by: Ian Vernon <ian@cilium.io>
Otherwise, subsequent calls when deleting maps will attempt to mount the BPFFS,
which will cause unit tests to fail on Travis with the following error:

```
level=fatal msg="Could not find BPF map root" subsys=bpf
```

Signed-off by: Ian Vernon <ian@cilium.io>
@ianvernon ianvernon force-pushed the pr/ianvernon/move-deadlock-unit-test branch from 311b4b3 to 7d2b1b5 Compare August 28, 2019 20:32
@ianvernon
Copy link
Member Author

test-me-please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 44.06% when pulling 7d2b1b5 on pr/ianvernon/move-deadlock-unit-test into 02eafbe on master.

@tgraf tgraf merged commit 3f7f66d into master Aug 29, 2019
@tgraf tgraf deleted the pr/ianvernon/move-deadlock-unit-test branch August 29, 2019 14:39
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants