Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endpointmanager: remove unneeded calls to UpdateLogger #9158

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

ianvernon
Copy link
Member

@ianvernon ianvernon commented Sep 7, 2019

NewEndpointWithState already calls UpdateLogger; there is no need to call it again.

Signed-off by: Ian Vernon ian@cilium.io


This change is Reviewable

`NewEndpointWithState` already calls `UpdateLogger`; there is no need to call it again.

Signed-off by: Ian Vernon <ian@cilium.io>
@ianvernon ianvernon added pending-review kind/cleanup This includes no functional changes. labels Sep 7, 2019
@ianvernon ianvernon requested a review from a team as a code owner September 7, 2019 01:52
@ianvernon
Copy link
Member Author

test-me-please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 44.21% when pulling f77cc76 on pr/ianvernon/update-logger-removal into 7887ab0 on master.

@aanm aanm merged commit 74b517b into master Sep 10, 2019
@aanm aanm deleted the pr/ianvernon/update-logger-removal branch September 10, 2019 00:42
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants