Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitor: Add TraceNotify.DataOffset() #9441

Merged
merged 1 commit into from
Oct 18, 2019
Merged

monitor: Add TraceNotify.DataOffset() #9441

merged 1 commit into from
Oct 18, 2019

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Oct 17, 2019 •
edited by tgraf
Loading

Provide a new function to access the offset of the data portion of a
TraceNotify message, depending on the version of the message being
decoded.

This change is Reviewable

@joestringer
monitor: Add TraceNotify.DataOffset()
ca390ee 
Provide a new function to access the offset of the data portion of a
TraceNotify message, depending on the version of the message being
decoded.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer added pending-review area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. labels Oct 17, 2019
@joestringer joestringer requested a review from a team as a code owner October 17, 2019 23:57
@joestringer
Copy link
Member Author

test-me-please

@michi-covalent
Copy link
Contributor

neat

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 45.583% when pulling ca390ee on joestringer:submit/monitor-data-offset into 286a9a4 on cilium:master.

@tgraf tgraf merged commit c1fbef4 into cilium:master Oct 18, 2019
@joestringer joestringer deleted the submit/monitor-data-offset branch October 18, 2019 21:28
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraf tgraf tgraf approved these changes

Assignees
No one assigned
Labels
area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joestringer @michi-covalent @coveralls @tgraf