api/v1: update swagger to v0.20.1 #9444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
kind/enhancement
|
test-me-please |
aanm
force-pushed
the
pr/update-swagger-to-v0.20.1
branch
from
15df65b
to
844541b
Compare
Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/update-swagger-to-v0.20.1
branch
from
844541b
to
f82573e
Compare
|
test-me-please |
|
@aanm are there any hand-written changes in this PR, or is it fully generated? |
aanm
commented
Oct 18, 2019
| @@ -16,7 +16,7 @@ BPF_FILES_EVAL := $(shell git ls-files $(ROOT_DIR)/bpf/ | grep -v .gitignore | t | |||
| BPF_FILES ?= $(BPF_FILES_EVAL) | |||
| BPF_SRCFILES := $(subst ../,,$(BPF_FILES)) | |||
|
|
|||
| SWAGGER_VERSION := v0.19.0 | |||
| SWAGGER_VERSION := v0.20.1 | |||
There was a problem hiding this comment.
Only this one @nebril , the rest was all auto generated. I mean there were some necessary refactoring in our code because swagger changed the name of IPAM to Ipam.
ianvernon
reviewed
Oct 18, 2019
| api.IPAMPostIPAMHandler = NewPostIPAMHandler(d) | ||
| api.IPAMPostIPAMIPHandler = NewPostIPAMIPHandler(d) | ||
| api.IPAMDeleteIPAMIPHandler = NewDeleteIPAMIPHandler(d) | ||
| api.IpamPostIpamHandler = NewPostIPAMHandler(d) |
There was a problem hiding this comment.
The fact that a code generator which deals with APIs thinks that changing case on APIs is OK is absurd to me... sigh.
ianvernon
approved these changes
Oct 18, 2019
vadorovsky
approved these changes
Oct 21, 2019
joestringer
added
the
release-note/misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: André Martins andre@cilium.io
This change is