Improve policy documentation #9763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
pending-review
release-note/misc
|
test-docs-please |
joestringer
commented
Dec 16, 2019
| @@ -276,6 +276,8 @@ func (d *Daemon) createEndpoint(ctx context.Context, epTemplate *models.Endpoint | |||
| } | |||
| } | |||
|
|
|||
| // The following docs describe the cases where the init identity is used: | |||
| // http://docs.cilium.io/en/latest/policy/lifecycle/#init-identity | |||
There was a problem hiding this comment.
I expect that this URL will work when we merge the code (tested with the #init-identity added at the end locally and compared with the heading links online). If not I can follow up to make sure it's right.
joestringer
force-pushed
the
submit/misc-docs-2019-12-16
branch
from
89229a3
to
2a7c667
Compare
|
test-docs-please |
aanm
reviewed
Dec 17, 2019
With the kubernetes Cilium CNI, the labels are typically fetched during endpoint creation, so the lifecycle text here was a bit out-of-date. Fix it up to be more clear in which cases the init identity is used, and reference it from the relevant code. Signed-off-by: Joe Stringer <joe@cilium.io>
Describe the restrictions of which traffic CIDR- and DNS-based policies apply in a bit more detail. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
submit/misc-docs-2019-12-16
branch
from
2a7c667
to
728fd7a
Compare
|
test-docs-please |
|
Hit #9779 on travis: https://travis-ci.com/cilium/cilium/builds/141609225 . Retrying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up some misc docs discrepancies:
This change is