Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tracee to projects list #23

Merged
merged 6 commits into from
Oct 29, 2020
Merged

add tracee to projects list #23

merged 6 commits into from
Oct 29, 2020

Conversation

itaysk
Copy link
Contributor

@itaysk itaysk commented Sep 15, 2020

src/pages/projects.js Outdated Show resolved Hide resolved
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

A few comments below. My main concern is the external image; other comments are minor.

src/pages/projects.js Outdated Show resolved Hide resolved
src/pages/projects.js Show resolved Hide resolved
src/pages/projects.js Outdated Show resolved Hide resolved
@itaysk itaysk requested review from tgraf and pchaigno October 16, 2020 13:35
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image file seems incorrect (see the preview).

LGTM otherwise!

src/assets/projects-logos/tracee.png Outdated Show resolved Hide resolved
@itaysk
Copy link
Contributor Author

itaysk commented Oct 20, 2020

@pchaigno I've checked the preview this time. Seems valid

@itaysk itaysk requested a review from pchaigno October 20, 2020 08:26
@lizrice
Copy link
Contributor

lizrice commented Oct 29, 2020

Gentle ping, would be lovely to get this merged

@joestringer joestringer merged commit 282d339 into ebpf-io:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants