Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI on 4.9 kernel #32

Closed
lmb opened this issue Nov 13, 2019 · 1 comment · Fixed by #36
Closed

Run CI on 4.9 kernel #32

lmb opened this issue Nov 13, 2019 · 1 comment · Fixed by #36
Assignees
@lmb
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lmb
Copy link
Collaborator

lmb commented Nov 13, 2019

Cilium requires at least Linux 4.9, which is why we added #5 We should run CI on 4.9 as well to make sure we don't regress. There are some tests which will fail, since the feature that is being tested is not supported on the old kernel. For now we probably need to skip those tests.

I've already built a 4.9 kernel: https://github.com/newtools/ci-kernels/blob/master/linux-4.9.198.bz
@lmb lmb added enhancement New feature or request good first issue Good for newcomers labels Nov 13, 2019
@lmb
Copy link
Collaborator Author

lmb commented Nov 28, 2019

Seems like the following things don't work:

  • Program.Test, Program.Benchmark (4.12)
  • Nested maps (4.12)
  • bpf2bpf function calls (4.16)
  • Reading a ProgramABI from /proc (probably a real bug)
  • Lookup on a ProgramArray
  • Attach / Detach (4.15?)

The we need to detect the running kernel version, and Skip() tests that are known to fail.

Most of the functions fail with EINVAL, ENOENT, etc. At some point we could add feature detection for all of these and return a nice error like "not supported", but that will get cumbersome quickly.

@lmb lmb self-assigned this Dec 2, 2019
lmb added a commit that referenced this issue Dec 2, 2019
@lmb
CI: run tests on 4.9.198
f4c08b8 
Add some helpers which allow skipping tests if the current kernel
version is too old. Also check that FeatureTests work.

Fixes #32
@lmb lmb mentioned this issue Dec 2, 2019
Merged
lmb added a commit that referenced this issue Dec 2, 2019
@lmb
CI: run tests on 4.9.198
e8433cd 
Add some helpers which allow skipping tests if the current kernel
version is too old. Also check that FeatureTests work.

Fixes #32
lmb added a commit that referenced this issue Dec 2, 2019
@lmb
CI: run tests on 4.9.198
9351154 
Add some helpers which allow skipping tests if the current kernel
version is too old. Also check that FeatureTests work.

Fixes #32
@lmb lmb closed this as completed in #36 Dec 3, 2019
lmb added a commit that referenced this issue Dec 3, 2019
@lmb
CI: run tests on 4.9.198
60c3aa4 
Add some helpers which allow skipping tests if the current kernel
version is too old. Also check that FeatureTests work.

Fixes #32
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmb lmb

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run unit tests on 4.9 kernels cilium/ebpf
1 participant
@lmb