tracefs: minor cleanups #1027
Merged
tracefs: minor cleanups #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the function so that the Go compiler can figure out that it really is a compile time constant. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Remove perfEvent.typ, since the only use is a check against prog.Type() in attachPerfEvent. This check already happens in kprobe() and uprobe() and so is not necessary. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
The cookie field is only used to pass a parameter to the perfEventAttach function. Remove it from perfEvent and pass the cookie directly. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
We currently set a finalizer in attachPerfEventLink and attachPerfEventIoctl. Instead always set a finalizer on the perfEvent to ensure that we close perf event and tracefs event in the right order. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracefs: use stringer for ProbeType
link: always set a finalizer on perfEvent
link: remove perfEvent.cookie
link: remove perfEvent.typ
link: remove unused perfEvent.group and name
internal: make PlatformPrefix a compile time constant