map: disentangle per-CPU handling #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's difficult to figure out what kind of types are valid to unmarshal into because "regular" and per-CPU values use the same code paths. This was done originally to cut down on duplicate code, but ultimately has just led to harder to read code. Handle per-CPU values in a separate code path. This in turn makes it easy to understand that the only valid types for per-CPU values are slices and pointers to slices. Zero-copy shenanigans with unsafe.Pointer are not supported. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
rgo3
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's difficult to figure out what kind of types are valid to unmarshal into because "regular" and per-CPU values use the same code paths. This was done originally to cut down on duplicate code, but ultimately has just led to harder to read code.
Handle per-CPU values in a separate code path. This in turn makes it easy to understand that the only valid types for per-CPU values are slices and pointers to slices. Zero-copy shenanigans with unsafe.Pointer are not supported.