-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link: implement uprobe/uretprobe #279
Conversation
8f674ba
to
7db6425
Compare
I've added unit tests; tests on v4.9 are failing because I think uprobes weren't available at all before v4.17: https://github.com/torvalds/linux/blob/v4.16/Documentation/trace/uprobetracer.rst Edit: nvm https://github.com/torvalds/linux/blob/v4.9/kernel/events/uprobes.c 🤔 |
It's probably okay to skip the test if |
https://elixir.bootlin.com/linux/v4.9/source/kernel/trace/Kconfig#L448 I think we need to set this explicitly here -> https://github.com/cilium/ci-kernels/blob/master/config (or skip the test) |
@mmat11 Tracking this in cilium/ci-kernels#11, feel free to add a conditional skip. |
Some last minute drive by comments, looks great! |
|
1936319
to
368856c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the refactor! Left a few readability comments, but solid overall. 👌
Signed-off-by: Mattia Meleleo <melmat@tuta.io>
Closes #277
TODO