Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add testing instructions to CONTRIBUTING.md #317

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

rgo3
Copy link
Contributor

@rgo3 rgo3 commented Jun 1, 2021

Signed-off-by: Robin Gögge r.goegge@outlook.com

@ti-mo ti-mo assigned lmb and ti-mo Jun 3, 2021
Copy link
Collaborator

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looping in @lmb because I'm not sure if we want to 'hardcode' 5.4 in the docs here, since it'll eventually go away.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@rgo3
Copy link
Contributor Author

rgo3 commented Jun 3, 2021

Fair point with the version, I picked it because it was the example from the script comment. Should I change it to something like ./run-tests.sh <kernel-version>?

@ti-mo
Copy link
Collaborator

ti-mo commented Jun 4, 2021

Fair point with the version, I picked it because it was the example from the script comment. Should I change it to something like ./run-tests.sh <kernel-version>?

Actually, 5.4 is LTS, so should be fine having it there. <kernel-version> doesn't tell the user which versions are available to test.

@rgo3
Copy link
Contributor Author

rgo3 commented Jun 4, 2021

Ok, Ill change the sudo command example and push the changes then :).

Signed-off-by: Robin Gögge <r.goegge@outlook.com>
@ti-mo
Copy link
Collaborator

ti-mo commented Jun 7, 2021

Thank you!

@ti-mo ti-mo merged commit f510d07 into cilium:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants