Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client certificate requests when no client certificate is specified #1123

Merged
merged 1 commit into from
Jul 13, 2023

Commits on Jul 13, 2023

  1. Fix client certificate requests when no client certificate is specified

    Only set GetClientCertificate if client certificate is configured.
    
    In docs for `GetClientCertificate` it specifies:
    
      GetClientCertificate must return a non-nil Certificate. If
      Certificate.Certificate is empty then no certificate will be sent to the
      server.
    
    If a nil certificate is sent when the server requests a client
    certificate, the client will return an error. Instead, only configure
    GetClientCertificate if certificates are provided and the server may
    choose to how to handle the lack of a client certificate.
    
    This is needed primarily for when the server is using RequestClientCert,
    which requests a certificate, but does not require the client to send
    one.
    
    Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
    chancez committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d218c72 View commit details
    Browse the repository at this point in the history