Fix client certificate requests when no client certificate is specified #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
chancez
force-pushed
the
pr/chancez/main/client_certs
branch
from
1e08c17
to
2f0276d
Compare
chancez
changed the title
chancez
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
chancez
commented
Jul 13, 2023
chancez
force-pushed
the
pr/chancez/main/client_certs
branch
from
2f0276d
to
6e85e84
Compare
Only set GetClientCertificate if client certificate is configured. In docs for `GetClientCertificate` it specifies: GetClientCertificate must return a non-nil Certificate. If Certificate.Certificate is empty then no certificate will be sent to the server. If a nil certificate is sent when the server requests a client certificate, the client will return an error. Instead, only configure GetClientCertificate if certificates are provided and the server may choose to how to handle the lack of a client certificate. This is needed primarily for when the server is using RequestClientCert, which requests a certificate, but does not require the client to send one. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
force-pushed
the
pr/chancez/main/client_certs
branch
from
6e85e84
to
d218c72
Compare
rolinh
added
the
needs-backport/0.12
rolinh
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only set GetClientCertificate if client certificate is configured.
In docs for
GetClientCertificateit specifies:If a nil certificate is sent when the server requests a client
certificate, the client will return an error. Instead, only configure
GetClientCertificate if certificates are provided and the server may
choose to how to handle the lack of a client certificate.
This is needed primarily for when the server is using RequestClientCert,
which requests a certificate, but does not require the client to send
one.
Previously, you would see this log message:
From the client when the server requested a client cert, even if it was not required.