Generate release binaries #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the install target does not fail if one runs `make install` without running `make` prior to that. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
This will allow setting the version in the file name of generated release binaries Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
When the `release` target is used, release binaries for various
platforms are generated. These binaries are gzip compressed and the
tarball SHA256 checksum is computed. Example:
$ make release
$ tree release
release
├── darwin
│ ├── 386
│ │ └── hubble
│ └── amd64
│ └── hubble
├── hubble-v0.7.0-dev-darwin-386.tar.gz
├── hubble-v0.7.0-dev-darwin-386.tar.gz.sha256sum
├── hubble-v0.7.0-dev-darwin-amd64.tar.gz
├── hubble-v0.7.0-dev-darwin-amd64.tar.gz.sha256sum
├── hubble-v0.7.0-dev-linux-386.tar.gz
├── hubble-v0.7.0-dev-linux-386.tar.gz.sha256sum
├── hubble-v0.7.0-dev-linux-amd64.tar.gz
├── hubble-v0.7.0-dev-linux-amd64.tar.gz.sha256sum
└── linux
├── 386
│ └── hubble
└── amd64
└── hubble
6 directories, 12 files
Note: only darwin (macos) and linux are supported at the moment as
hubble lacks windows support.
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
gandro
reviewed
Jun 4, 2020
Makefile
Outdated
| for OS in darwin linux; do \ | ||
| for ARCH in 386 amd64; do \ | ||
| test -d release/$$OS/$$ARCH|| mkdir -p release/$$OS/$$ARCH; \ | ||
| env GOOS=$$OS GOARCH=$$ARCH $(GO) build $(if $(GO_TAGS),-tags $(GO_TAGS)) -ldflags "-w -s -X 'github.com/cilium/hubble/pkg.Version=${VERSION}'" -o release/$$OS/$$ARCH/$(TARGET); \ |
There was a problem hiding this comment.
nit: Can we extract a common variable/macro for the build flags (-tags, -w, -s, -X etc)?
gandro
requested changes
Jun 4, 2020
This allows hubble to be built for Windows as well. Note that `os.Interrupt` is the only signal value that is guaranteed to be present on all systems (along with `os.Kill`). This means that `unix.SIGTERM` has been dropped and is no longer handled. This should however be fine as hubble is now only run as a command-line program and `os.Interrupt` is the signal that is sent by `ctrl-c`. In effect, this means that users are still able to interrupt a `hubble observe --follow` command. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/rolinh/release-binaries
branch
from
16f0dd8
to
80fb448
Compare
gandro
approved these changes
Jun 4, 2020
michi-covalent
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.