observe: Document default flow count output #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't tell from the help text what the intended default was here, but there seems to be some special logic to try to ensure that the number of flows is only restricted when no other selector parameters are specified. Manually add the default string at the end so that we don't have to restrict the number of flows to 20 by default when specifying other selector criteria, but it's still apparent what the default behaviour is. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
⌨️ area/cli
michi-covalent
approved these changes
Jul 13, 2020
|
That said I think your approach is ok to use here instead of the default helpers for cobra since we'd like to know if the user actually set it to 20, or that's just the default (makes error handling easier without propagating the default value everywhere). |
glibsm
approved these changes
Jul 13, 2020
Ah cool, I wasn't sure but I figured I'd go for the minimal change here since I'm sure it was written this way for a reason. |
kaworu
approved these changes
Jul 14, 2020
rolinh
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't tell from the help text what the intended default was here,
but there seems to be some special logic to try to ensure that the
number of flows is only restricted when no other selector parameters are
specified. Manually add the default string at the end so that we don't
have to restrict the number of flows to 20 by default when specifying
other selector criteria, but it's still apparent what the default
behaviour is.