Update Cilium dep and fix unit tests that subsequently broke #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that due to this bug[0] in the `testify` library some unit tests started failing. See this issue[1] for more details. [0]: stretchr/testify#930 [1]: cilium/cilium#12772 Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Use `go-cmp` to rewrite assertion that started to fail after a cilium dep upgrade due to a `testify` bug[0]. More details in this issue[1]. This pulls in `github.com/google/go-cmp` as an explicit dependency. [0]: stretchr/testify#930 [1]: cilium/cilium#12772 Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
added
🤖 area/CI
michi-covalent
approved these changes
Aug 5, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
glibsm
reviewed
Aug 5, 2020
Comment on lines
+100
to
+101
| cmpopts.IgnoreUnexported(pb.FlowFilter{}), | ||
| cmpopts.IgnoreUnexported(pb.EventTypeFilter{}), |
There was a problem hiding this comment.
is this just future-proofing, or the test doesn't pass without these?
There was a problem hiding this comment.
When omitted, one gets a panic with the following message:
--- FAIL: TestFilterDispatch (0.00s)
panic: cannot handle unexported field at {[]*flow.FlowFilter}[0].EventType[0].state:
"github.com/cilium/cilium/api/v1/flow".EventTypeFilter
consider using a custom Comparer; if you control the implementation of type, you can also consider using an Exporter, AllowUnexported, or cmpopts.IgnoreUnexported [recovered]
panic: cannot handle unexported field at {[]*flow.FlowFilter}[0].EventType[0].state:
"github.com/cilium/cilium/api/v1/flow".EventTypeFilter
consider using a custom Comparer; if you control the implementation of type, you can also consider using an Exporter, AllowUnexported, or cmpopts.IgnoreUnexported
glibsm
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Cilium dep to latest and use
go-cmpto rewrite assertion that started to fail after a cilium dep upgrade due to atestifybug.This pulls in
github.com/google/go-cmpas an explicit dependency.Ref: cilium/cilium#12772