printer: Display security identity in compact output #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
⌨️ area/cli
This commit changes the default compact mode output to always display the Cilium security identity. This is very useful when debugging policy related issues, as those often occur when an endpoint does not have the expected security identity assigned to it. Before: `1.1.1.1:31793 -> 2.2.2.2:8080` After: `1.1.1.1:31793 (health) -> 2.2.2.2:8080 (identity:12345)` Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/add-numeric-identity-to-compact-output
branch
from
f677537
to
c092301
Compare
michi-covalent
approved these changes
May 12, 2022
michi-covalent
deleted the
pr/gandro/add-numeric-identity-to-compact-output
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the default compact mode output to always display
the Cilium security identity. This is very useful when debugging policy
related issues, as those often occur when an endpoint does not have the
expected security identity assigned to it.
Screenshot below. Note the magenta
(identity)fields which are added by this PR.There is no flag to disable those identities in compact mode. Users who rely on stable output are asked to use the
jsonorjsonpboutput.