named reserved identites support for --{,from-,to-}identity
#732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, the identity flags errors were very verbose:
% hubble observe --identity foo
invalid argument "foo" for "--identity" flag: invalid security identity: foo: strconv.ParseUint: parsing "foo": invalid syntax
This patch shorten the error message to:
% hubble observe --identity foo
invalid argument "foo" for "--identity" flag: invalid security identity
The next commit will introduce support for named special identities,
which would render the integer parsing message moot.
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
added
kind/enhancement
rolinh
reviewed
Jun 1, 2022
gandro
approved these changes
Jun 1, 2022
maintainer-s-little-helper
bot
added
the
ready-to-merge
kaworu
force-pushed
the
pr/kaworu/named-reserved-identites
branch
from
51acd7e
to
ccd709f
Compare
|
@rolinh updated with completion and list valid values on error, please take another look. error messagecompletion |
kaworu
force-pushed
the
pr/kaworu/named-reserved-identites
branch
from
ccd709f
to
846d52d
Compare
rolinh
approved these changes
Jun 1, 2022
Comment on lines
+497
to
+505
| observeCmd.RegisterFlagCompletionFunc("identity", func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) { | ||
| return reservedIdentitiesNames(), cobra.ShellCompDirectiveDefault | ||
| }) | ||
| observeCmd.RegisterFlagCompletionFunc("to-identity", func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) { | ||
| return reservedIdentitiesNames(), cobra.ShellCompDirectiveDefault | ||
| }) | ||
| observeCmd.RegisterFlagCompletionFunc("from-identity", func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) { | ||
| return reservedIdentitiesNames(), cobra.ShellCompDirectiveDefault | ||
| }) |
kaworu
force-pushed
the
pr/kaworu/named-reserved-identites
branch
2 times, most recently
from
0697f79
to
4dbf58f
Compare
f7c66cc ("printer: Display security identity in compact output") introduced display of security identities including named reserved identities, e.g. "(host)" instead of the equivalent "(identity:1)". Before this patch, the --identity, --from-identity, and --to-identity flags would only accept numerical values. This patch introduce support for named reserved identites such as "host", "world", etc. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
gandro
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#717 introduced display of security identity in the (default) compact output, which is awesome. While trying to copy/paste identities from the Hubble CLI output to its
--identityflag, I found that named reserved identities were not supported.After this patch, we can write
hubble observe --identity worldinstead ofhubble observe --label reserved:world.