Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go to 1.18.3, alpine to 3.16, golangci-lint to 1.46.2 #737

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Update Go to 1.18.3, alpine to 3.16, golangci-lint to 1.46.2 #737

merged 2 commits into from
Jun 7, 2022

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Jun 7, 2022

No description provided.

@tklauser
ci, make: update golangci-lint to 1.46.2
36a420c 
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser requested review from a team as code owners June 7, 2022 08:39
@tklauser tklauser requested review from a team and nbusseneau and removed request for a team June 7, 2022 08:39
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Jun 7, 2022
@tklauser tklauser requested review from glibsm and removed request for a team June 7, 2022 08:40
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Jun 7, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Jun 7, 2022
kaworu
kaworu approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we upgrade to alpine-3.16 on the way?

@tklauser
Copy link
Member Author

tklauser commented Jun 7, 2022

LGTM, should we upgrade to alpine-3.16 on the way?

Good point. Will update as well.

@tklauser
Update Go to 1.18.3, alpine to 3.16
811ec24 
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/update-go-1.18.3 branch from d32816c to 811ec24 Compare June 7, 2022 09:22
@tklauser tklauser changed the title Update Go to 1.18.3, golangci-lint to 1.46.2 Update Go to 1.18.3, alpine to 3.16, golangci-lint to 1.46.2 Jun 7, 2022
@rolinh rolinh removed the request for review from glibsm June 7, 2022 15:15
@rolinh rolinh merged commit 7f83a0f into master Jun 7, 2022
@rolinh rolinh deleted the pr/tklauser/update-go-1.18.3 branch June 7, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@rolinh rolinh rolinh approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tklauser @kaworu @rolinh @nbusseneau